-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: codemod ExtensionCard
component to CSS modules
#24782
Merged
valerybugakov
merged 5 commits into
main
from
vb/css-modules-codemod-web-extension-card
Sep 10, 2021
Merged
web: codemod ExtensionCard
component to CSS modules
#24782
valerybugakov
merged 5 commits into
main
from
vb/css-modules-codemod-web-extension-card
Sep 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerybugakov
added
frontend-platform
Issues related to our frontend platform, owned collectively by our frontend crew.
dx
Issues and PRs related to developer experience concerns
CSS Modules migration
labels
Sep 9, 2021
54 tasks
Notifying subscribers in CODENOTIFY files for diff 9724fc3...3352eee.
|
umpox
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
valerybugakov
commented
Sep 9, 2021
tjkandala
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dx
Issues and PRs related to developer experience concerns
frontend-platform
Issues related to our frontend platform, owned collectively by our frontend crew.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR results from the global-css-to-css-modules codemod application with some manual fixes, caused by the usage of global CSS classes tied to a React component in other parts of the codebase: e.g.,
.sidebar
class used outside of the<Sidebar />
component.Changes
ExtensionCard
stylesheet is converted to the CSS module.